chore(db): Drop unsed index on key column in Commit table
#91610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for for --
-- Alter field key on commit
--
DROP INDEX CONCURRENTLY IF EXISTS "sentry_commit_key_a5b0367e";
DROP INDEX CONCURRENTLY IF EXISTS "sentry_commit_key_a5b0367e_like"; |
beezz
approved these changes
May 14, 2025
vgrozdanic
added a commit
that referenced
this pull request
May 14, 2025
…#91611) Similar as in #91610, index on `last_seen` column hasn't been used since Oct 29th (since then we track the usage), and it takes 674GiB of disk in our main US DB. I went through our codebase and couldn't find any query that would still be using this index. On our main US DB (and some other single tenants) this will be executed by an SRE, since dropping the index will likely timeout, even as a post deployment migration. For other regions, this index is small enough to be removed as a post deployment migration
|
fwiw - dropping an index concurrently should be fast |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This index was last used on Oct 29th, and it consumes almost 100gb in our main SaaS DB, so there is no reason to keep it.
I went through our codebase and couldn't find any query that would still be using this index. On our main US DB this should probably be executed by an SRE, since dropping the index could timeout, even as a post deployment migration. In other regions, index size is small enough to be run as a regular post deployment migration job.