From db0becb67901fd71f968c6992b212bcde474cde0 Mon Sep 17 00:00:00 2001 From: Vjeran Grozdanic Date: Wed, 14 May 2025 10:30:22 +0200 Subject: [PATCH] chore(db): Drop unsed index on key column in Commit table --- migrations_lockfile.txt | 2 +- .../0889_remove_index_on_key_field.py | 33 +++++++++++++++++++ src/sentry/models/commit.py | 2 +- 3 files changed, 35 insertions(+), 2 deletions(-) create mode 100644 src/sentry/migrations/0889_remove_index_on_key_field.py diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index 313ab32857d3d5..d0f3135eca17fb 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -21,7 +21,7 @@ remote_subscriptions: 0003_drop_remote_subscription replays: 0004_index_together -sentry: 0888_groupopenperiod_gist_index_in_code +sentry: 0889_remove_index_on_key_field social_auth: 0002_default_auto_field diff --git a/src/sentry/migrations/0889_remove_index_on_key_field.py b/src/sentry/migrations/0889_remove_index_on_key_field.py new file mode 100644 index 00000000000000..ce147191cff1de --- /dev/null +++ b/src/sentry/migrations/0889_remove_index_on_key_field.py @@ -0,0 +1,33 @@ +# Generated by Django 5.2.1 on 2025-05-14 08:26 + +from django.db import migrations, models + +from sentry.new_migrations.migrations import CheckedMigration + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = True + + dependencies = [ + ("sentry", "0888_groupopenperiod_gist_index_in_code"), + ] + + operations = [ + migrations.AlterField( + model_name="commit", + name="key", + field=models.CharField(max_length=64), + ), + ] diff --git a/src/sentry/models/commit.py b/src/sentry/models/commit.py index 91d57eb30c1ca2..dab398f8a33158 100644 --- a/src/sentry/models/commit.py +++ b/src/sentry/models/commit.py @@ -39,7 +39,7 @@ class Commit(Model): organization_id = BoundedBigIntegerField(db_index=True) repository_id = BoundedPositiveIntegerField() - key = models.CharField(max_length=64, db_index=True) + key = models.CharField(max_length=64) date_added = models.DateTimeField(default=timezone.now) # all commit metadata must be optional, as it may not be available # when the initial commit object is referenced (and thus created)