-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Dogfood Python SDK 3.0.0 alpha #91614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PoC of monkey patching sentry_sdk in runtime
|
Tests completed | Failed | Passed | Skipped |
---|---|---|---|
25937 | 7623 | 18314 | 304 |
View the top 3 failed test(s) by shortest run time
tests.sentry.integrations.vsts.test_issues.VstsIssueFormTest::test_default_project_error_on_default_project
Stack Traces | 0.012s run time
#x1B[1m#x1B[31mtests/conftest.py#x1B[0m:146: in check_leaked_responses_mocks raise AssertionError( #x1B[1m#x1B[31mE AssertionError: `responses` were leaked outside of the test context:#x1B[0m #x1B[1m#x1B[31mE - <Response(url='https://fabrikam-fiber-inc.visualstudio..../workitemtypes/Bug/states' status=200 content_type='application/json' headers='null')>#x1B[0m #x1B[1m#x1B[31mE - <Response(url='https://fabrikam-fiber-inc.visualstudio.com/_apis/projects' status=200 content_type='application/json' headers='null')>#x1B[0m #x1B[1m#x1B[31mE (make sure to use `@responses.activate` or `with responses.mock:`)#x1B[0m
tests.sentry.integrations.vsts.test_issues.VstsIssueFormTest__InMonolithMode::test_get_create_issue_config_error_on_get_projects
Stack Traces | 0.012s run time
#x1B[1m#x1B[31mtests/conftest.py#x1B[0m:146: in check_leaked_responses_mocks raise AssertionError( #x1B[1m#x1B[31mE AssertionError: `responses` were leaked outside of the test context:#x1B[0m #x1B[1m#x1B[31mE - <Response(url='https://fabrikam-fiber-inc.visualstudio..../workitemtypes/Bug/states' status=200 content_type='application/json' headers='null')>#x1B[0m #x1B[1m#x1B[31mE - <Response(url='https://fabrikam-fiber-inc.visualstudio.com/_apis/projects' status=200 content_type='application/json' headers='null')>#x1B[0m #x1B[1m#x1B[31mE (make sure to use `@responses.activate` or `with responses.mock:`)#x1B[0m
tests.sentry.integrations.vsts.test_issues.VstsIssueFormTest__InMonolithMode::test_default_project_and_category
Stack Traces | 0.014s run time
#x1B[1m#x1B[31mtests/conftest.py#x1B[0m:146: in check_leaked_responses_mocks raise AssertionError( #x1B[1m#x1B[31mE AssertionError: `responses` were leaked outside of the test context:#x1B[0m #x1B[1m#x1B[31mE - <Response(url='https://fabrikam-fiber-inc.visualstudio..../workitemtypes/Bug/states' status=200 content_type='application/json' headers='null')>#x1B[0m #x1B[1m#x1B[31mE - <Response(url='https://fabrikam-fiber-inc.visualstudio.com/_apis/projects' status=200 content_type='application/json' headers='null')>#x1B[0m #x1B[1m#x1B[31mE (make sure to use `@responses.activate` or `with responses.mock:`)#x1B[0m
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like a really bad idea. why does this need special treatment? do we not expect s4s and canary to catch issues?
if in_random_rollout("sentry-sdk.use-python-sdk-alpha"): | ||
redirect_import("sentry_sdk", "sentry_sdk_alpha") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options can't / shouldn't be used at import time (as they require a database call)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not to mention they won't be reflected upon update -- as they will be read exactly once during startup and then never again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, noted. I will try something.
Because we use now OpenTelemetry under the hood it might happen that:
Can s4s or canary detect such issues? |
@asottile-sentry can you help to figure out a way to gradually roll out the alpha sdk? (we have to packages on pypi ( |
I don't see why not -- should be pretty easy to see a cpu / memory regression (it'll likely result in a crashloop) -- as for tags I'd just manually look at a few during the soak period (~5 minutes) and if you're not happy pause and revert. |
we routinely upgrade packages, the interpreter, django, etc. without special treatment -- I don't see why the sdk would need extra special care comparatively |
Ok, thanks for all the input @asottile-sentry ! We will not move on with this and will do the regular deployment for testing the SDK alpha. I will close this in favor of #92011 |
We will soon release a new major version of the Sentry Python SDK:
3.0.0
.This PR prepares the
sentry
code base to use the new major release and update the code to make it work with the new API.We will then gradually deploy this to some nodes of Sentry and monitor if any problems arise.