Skip to content

fix(notifications): Convert slack notification title to rich text #91637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

snigdhas
Copy link
Member

@snigdhas snigdhas commented May 14, 2025

Converting the title for slack notifications to use rich text instead of markdown so the issue title link works for iOS. This is a known issue with Slack's iOS app.

Visually, there should be no change here.

Fixes #82961

image image

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 14, 2025
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 97.63780% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sentry/notifications/notifications/test_digests.py 66.66% 5 Missing ⚠️
...y/integrations/slack/message_builder/base/block.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #91637      +/-   ##
==========================================
+ Coverage   85.40%   87.92%   +2.51%     
==========================================
  Files       10178    10141      -37     
  Lines      583542   582448    -1094     
  Branches    22639    22445     -194     
==========================================
+ Hits       498366   512104   +13738     
+ Misses      84724    69930   -14794     
+ Partials      452      414      -38     

@snigdhas snigdhas marked this pull request as ready for review May 16, 2025 20:08
@snigdhas snigdhas requested review from a team as code owners May 16, 2025 20:08
@cathteng
Copy link
Member

lgtm on block kit builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression notifications in Slack do not link to Issue (on mobile)
2 participants