Skip to content

chore(seer): update seer references #91642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 16, 2025
Merged

Conversation

trillville
Copy link
Contributor

rename all autofix refs to seer

@trillville trillville requested review from a team as code owners May 14, 2025 16:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 14, 2025
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
@@ -185,7 +185,7 @@ export function SeerDrawer({group, project, event}: SeerDrawerProps) {
</SeerDrawerHeader>
<SeerDrawerNavigator>
<Flex align="center" gap={space(1)}>
<Header>{t('Autofix')}</Header>
<Header>{t('Seer')}</Header>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it say Seer or Issue Fix or something else describing the feature inside this drawer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either works. The flyover is opened when you click on a button inside a box called "Seer", so there's a "link" (visually) there. I think "Seer" is fine here.

@roaga
Copy link
Member

roaga commented May 14, 2025

You're also gonna need to update tests

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91642       +/-   ##
===========================================
+ Coverage   59.05%   87.62%   +28.56%     
===========================================
  Files       10344    10330       -14     
  Lines      586202   585568      -634     
  Branches    22560    22469       -91     
===========================================
+ Hits       346175   513083   +166908     
+ Misses     239438    72067   -167371     
+ Partials      589      418      -171     

Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions on some small changes unrelated to the naming that are being included here

@@ -95,7 +95,7 @@ export function AutofixStartBox({onSend, groupId}: AutofixStartBoxProps) {
}
analyticsParams={{group_id: groupId}}
>
{t('Start Autofix')}
{t('Start Seer')}
Copy link
Member

@roaga roaga May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that summary and scanner are all part of Seer, wonder if this should be something like "Start Analysis". This is fine though

@@ -153,10 +153,7 @@ export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNotice
</Fragment>
)}
{nonGithubRepos.length > 0 && (
<Fragment>
{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this space here doing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bc89939 looks like the automated linter is doing it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that's fine

@trillville trillville enabled auto-merge (squash) May 16, 2025 18:17
@trillville trillville merged commit df14bba into master May 16, 2025
42 checks passed
@trillville trillville deleted the trillville/update-seer-names branch May 16, 2025 18:32
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
rename all autofix refs to seer

---------

Co-authored-by: Rohan Agarwal <47861399+roaga@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants