-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(seer): update seer references #91642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
@@ -185,7 +185,7 @@ export function SeerDrawer({group, project, event}: SeerDrawerProps) { | |||
</SeerDrawerHeader> | |||
<SeerDrawerNavigator> | |||
<Flex align="center" gap={space(1)}> | |||
<Header>{t('Autofix')}</Header> | |||
<Header>{t('Seer')}</Header> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it say Seer or Issue Fix or something else describing the feature inside this drawer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either works. The flyover is opened when you click on a button inside a box called "Seer", so there's a "link" (visually) there. I think "Seer" is fine here.
You're also gonna need to update tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91642 +/- ##
===========================================
+ Coverage 59.05% 87.62% +28.56%
===========================================
Files 10344 10330 -14
Lines 586202 585568 -634
Branches 22560 22469 -91
===========================================
+ Hits 346175 513083 +166908
+ Misses 239438 72067 -167371
+ Partials 589 418 -171 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions on some small changes unrelated to the naming that are being included here
@@ -95,7 +95,7 @@ export function AutofixStartBox({onSend, groupId}: AutofixStartBoxProps) { | |||
} | |||
analyticsParams={{group_id: groupId}} | |||
> | |||
{t('Start Autofix')} | |||
{t('Start Seer')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that summary and scanner are all part of Seer, wonder if this should be something like "Start Analysis". This is fine though
@@ -153,10 +153,7 @@ export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNotice | |||
</Fragment> | |||
)} | |||
{nonGithubRepos.length > 0 && ( | |||
<Fragment> | |||
{' '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this space here doing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bc89939 looks like the automated linter is doing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok that's fine
rename all autofix refs to seer --------- Co-authored-by: Rohan Agarwal <47861399+roaga@users.noreply.github.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
rename all autofix refs to seer