perf(alerts): Limit GroupEvent processing to relevant groups #91659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ Error parsing JUnit XML in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml at 1:159170 Caused by: Additional details and impacted files@@ Coverage Diff @@
## master #91659 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 10349 10349
Lines 586396 586409 +13
Branches 22559 22559
=======================================
+ Hits 513954 513968 +14
+ Misses 71996 71995 -1
Partials 446 446 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
Restrict our rulegroup_to_eventdata mapping in `get_group_to_groupevent` to relevant groups early on. This means that instead of fetching every event and occurrence for every rule, it only fetches those for the groups currently being processed. Logic below in `build_group_to_groupevent` already walks this mapping and drops any that aren't in our set of passed in Groups (logging them as missing), so the end result should be the same (though with less log noise). It's not clear how much perf benefit we expect to see from this, but it does make the behavior a bit clearer, avoids suspicious logs in a situation that is expected, and potentially asks significantly less work of our nodestore bulk fetches, so it seems promising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict our rulegroup_to_eventdata mapping in
get_group_to_groupeventto relevant groups early on.This means that instead of fetching every event and occurrence for every rule, it only fetches those for the groups currently being processed.
Logic below in
build_group_to_groupeventalready walks this mapping and drops any that aren't in our set of passed in Groups (logging them as missing), so the end result should be the same (though with less log noise).It's not clear how much perf benefit we expect to see from this, but it does make the behavior a bit clearer, avoids suspicious logs in a situation that is expected, and potentially asks significantly less work of our nodestore bulk fetches, so it seems promising.