-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(typescript): Switch to --moduleResolution bundler
, remove duplicate properties, remove @ts-expect-error
comments
#91686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…e `@ts-ignore` comments.
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
--moduleResolution bundler
, remove duplicate properties, remove @ts-ignore
comments
--moduleResolution bundler
, remove duplicate properties, remove @ts-ignore
comments--moduleResolution bundler
, remove duplicate properties, remove @ts-expect-error
comments
@DanielRosenwasser I'm seeing the following output, but its obvs set to be
from: https://github.com/getsentry/sentry/actions/runs/15033225703/job/42249995049?pr=91686 |
I think this is resolved in Jest 30 (not released yet!): |
@DanielRosenwasser that jest pr was helpful, i think you can force that mode just for ts-node. We only use ts-node for webpack and jest configs and this would kinda backport the change. "ts-node": {
"transpileOnly": true,
"compilerOptions": {
"moduleResolution": "Node10"
}
} |
Related to #90413.
In order to cleanly measure relative performance improvements in the native port of the TypeScript compiler, this change removes some errors found by compiling with tsgo. Specifically:
@ts-expect-error
comments have been removed (thanks to newmoduleResolution
settings`)@emotion/styled
have been replaced by updating an existing top-level importbundler
because--moduleResolution node
a.k.a.node10
will be deprecated in TypeScript 6.0--moduleResolution nodenext
will not work because many existing paths inimport()
calls lack a file extensionLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.