From a65db2a3e9a98c451e20724d47f2fff35fb7b8f1 Mon Sep 17 00:00:00 2001 From: anthony sottile Date: Wed, 14 May 2025 14:51:41 -0400 Subject: [PATCH] ref: fix nullability of requires_org_level_access column was erroneously added as nullable mismatching the schema ~100k rows, 0 nulls --- migrations_lockfile.txt | 2 +- .../0896_org_level_access_not_null.py | 35 +++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 src/sentry/migrations/0896_org_level_access_not_null.py diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index 383dd7d7a20852..58776125f75f56 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -21,7 +21,7 @@ remote_subscriptions: 0003_drop_remote_subscription replays: 0005_drop_replay_index -sentry: 0895_relocation_provenance_smallint +sentry: 0896_org_level_access_not_null social_auth: 0002_default_auto_field diff --git a/src/sentry/migrations/0896_org_level_access_not_null.py b/src/sentry/migrations/0896_org_level_access_not_null.py new file mode 100644 index 00000000000000..8a1afdffdbfc77 --- /dev/null +++ b/src/sentry/migrations/0896_org_level_access_not_null.py @@ -0,0 +1,35 @@ +# Generated by Django 5.2.1 on 2025-05-14 18:49 + +from sentry.new_migrations.migrations import CheckedMigration +from sentry.new_migrations.monkey.special import SafeRunSQL + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = False + + dependencies = [ + ("sentry", "0895_relocation_provenance_smallint"), + ] + + operations = [ + SafeRunSQL( + """ + ALTER TABLE sentry_apiapplication + ALTER COLUMN requires_org_level_access SET NOT NULL + """, + reverse_sql="", + hints={"tables": ["sentry_apiapplication"]}, + ), + ]