Skip to content

ref: put refs closer to typedef #91757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

ref: put refs closer to typedef #91757

merged 1 commit into from
May 15, 2025

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented May 15, 2025

This is likely adding pressure on the type checker, as intersections with large types are a struggle for the compiler to process

@JonasBa JonasBa requested review from a team as code owners May 15, 2025 18:31
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 15, 2025
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good cleanup

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #91757   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files       10336    10336           
  Lines      586493   586454   -39     
  Branches    22552    22552           
=======================================
- Hits       499268   499238   -30     
+ Misses      86779    86770    -9     
  Partials      446      446           

@JonasBa JonasBa force-pushed the jb/ref/interface branch from 477581f to 91cbfd5 Compare May 15, 2025 18:49
@JonasBa JonasBa enabled auto-merge (squash) May 15, 2025 18:55
@JonasBa JonasBa merged commit 5873681 into master May 15, 2025
41 checks passed
@JonasBa JonasBa deleted the jb/ref/interface branch May 15, 2025 19:04
andrewshie-sentry pushed a commit that referenced this pull request May 15, 2025
This is likely adding pressure on the type checker, as intersections
with large types are a struggle for the compiler to process
@TkDodo
Copy link
Contributor

TkDodo commented May 19, 2025

awesome, thank you 🙏 . The intersection with an object containing ref was made by the codemod provided by react, I guess because it’s the easiest way to put refs as a prop on there consistently. Moving that to our own types is better 👍

@JonasBa
Copy link
Member Author

JonasBa commented May 19, 2025

awesome, thank you 🙏 . The intersection with an object containing ref was made by the codemod provided by react, I guess because it’s the easiest way to put refs as a prop on there consistently. Moving that to our own types is better 👍

Not a problem at all, I hope we get tsgo soon so that this isn't even an issue going forward :D

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants