feat(aci): add edit monitors drawer and link monitor creation page #91761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
May 15, 2025
| </DrawerBody> | ||
| </div> | ||
| ), | ||
| {ariaLabel: 'Details'} |
There was a problem hiding this comment.
non obvious but this needs a drawerKey for resizing
scttcper
reviewed
May 15, 2025
Comment on lines
+71
to
+76
| <div> | ||
| <DrawerHeader /> | ||
| <DrawerBody> | ||
| <EditConnectedMonitors storageKey={storageKey} /> | ||
| </DrawerBody> | ||
| </div> |
There was a problem hiding this comment.
i'd pull this into its own component as soon as we need to add more things
scttcper
approved these changes
May 15, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
…91761) **"Create New Monitor"** now links to the monitor creation page **"Edit Monitors"** now opens a new drawer to connect/disconnect monitors <img width="1219" alt="Screenshot 2025-05-15 at 11 44 11 AM" src="https://github.com/user-attachments/assets/050c6956-e4d2-4362-a8c0-014e921614e9" /> doesn't look like much without mock data <img width="1486" alt="Screenshot 2025-05-15 at 11 42 48 AM" src="https://github.com/user-attachments/assets/38a409c0-cbd0-40b8-aaaa-901b553fa7e4" /> **designs with mock data:** <img width="410" alt="Screenshot 2025-05-15 at 11 47 17 AM" src="https://github.com/user-attachments/assets/06929b99-fd6e-44cc-a8b5-20a9891354ce" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Create New Monitor" now links to the monitor creation page
"Edit Monitors" now opens a new drawer to connect/disconnect monitors
doesn't look like much without mock data
designs with mock data:
