Skip to content

chore(aci): manually add spans in delayed processing task #91764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

cathteng
Copy link
Member

We are missing instrumentation to be able to debug SoftTimeout errors in delayed processing. Manually add the spans here

@cathteng cathteng requested a review from a team May 15, 2025 19:06
@cathteng cathteng requested a review from a team as a code owner May 15, 2025 19:06
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/rules/processing/delayed_processing.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #91764      +/-   ##
==========================================
+ Coverage   82.62%   87.61%   +4.99%     
==========================================
  Files       10334    10337       +3     
  Lines      586508   586476      -32     
  Branches    22551    22543       -8     
==========================================
+ Hits       484611   513863   +29252     
+ Misses     101452    72168   -29284     
  Partials      445      445              

@cathteng cathteng requested a review from kcons May 15, 2025 20:21
@cathteng cathteng merged commit 58bb4d4 into master May 15, 2025
61 checks passed
@cathteng cathteng deleted the cathy/aci/delayed-processing-spans branch May 15, 2025 21:33
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants