tests(resolve_groups): Clean up the tests #91779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armenzg
commented
May 15, 2025
| @@ -240,7 +240,7 @@ def setUp(self): | |||
| self.secret = "b3002c3e321d4b7880360d397db2ccfd" | |||
| options.set("github-app.webhook-secret", self.secret) | |||
|
|
|||
| def _setup_repo_test(self, project): | |||
| def _create_integration_and_send_push_event(self): | |||
There was a problem hiding this comment.
This makes it clearer what this helper function does.
| @@ -576,7 +576,7 @@ def setUp(self): | |||
| self.secret = "b3002c3e321d4b7880360d397db2ccfd" | |||
| options.set("github-app.webhook-secret", self.secret) | |||
|
|
|||
| def _setup_repo_test(self, project): | |||
| def _create_integration_and_send_pull_request_opened_event(self): | |||
There was a problem hiding this comment.
This makes it clearer what this helper function does.
There was a problem hiding this comment.
This whole test we may want to delete, as I believe it may be converted by tests for event_manager or webhooks.
| linked_type=GroupLink.LinkedType.pull_request, | ||
| linked_id=pr.id, | ||
| ).exists() | ||
| # XXX: Oddly,resolved_in_pull_request doesn't update the group status |
There was a problem hiding this comment.
Unlike resolved_in_commit, this function doesn't resolve the group. Maybe it's intentional.
sentry/src/sentry/receivers/releases.py
Lines 224 to 248 in ef23ce0
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91779 +/- ##
==========================================
+ Coverage 78.83% 87.65% +8.82%
==========================================
Files 10333 10336 +3
Lines 586475 586181 -294
Branches 22548 22548
==========================================
+ Hits 462337 513843 +51506
+ Misses 123692 71892 -51800
Partials 446 446 |
scttcper
approved these changes
May 15, 2025
jan-auer
added a commit
that referenced
this pull request
May 20, 2025
* master: (58 commits) link: cleanup link (#91687) ref: create project_id index for organizationonboardingtask (#91918) storybook: smaller last edited (#91875) issues: fix chonk stacktrace alignment (#91891) alert: drop custom alert (#91892) insights: fix bar height (#91895) ref(span-buffer): Move max-memory-percentage to right CLI (#91924) ref(js): Factor button functionality (#91763) tests(resolve_groups): Clean up the tests (#91779) ref(span-buffer): Add backpressure (#91707) fix(nextjs-insights): project id is not passed to explore link (#91920) fix(crons): Floor seconds / microsecond on recorded dateClock (#91890) fix(uptime): Fix bug with the uptime_checks dataset in the events endpoint (#91824) ref: add state-only migration to reflect existing indexes in prod (#91901) ref: remove unnecssary metaclass (#91906) fix(stats): use data category title name (#91913) feat(issues): Add success messages to some actions (#91899) test(taskworker): Lower exec time (#91907) chore(aci): manually add spans for delayed workflow processing (#91908) chore(aci): remove uses of WorkflowFireHistory rollout columns (#91904) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
This fixes and makes it clearer some of the tests for resolving groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes and makes it clearer some of the tests for resolving groups.