Skip to content

feat(ui): Use pathname as the ScrollRestoration key #91780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

narsaynorath
Copy link
Member

Prevents URL changes such as query params from changing the scroll unexpectedly.

Prevents URL changes such as query params from changing the scroll
unexpectedly.
@narsaynorath narsaynorath requested a review from scttcper May 15, 2025 22:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 15, 2025
@narsaynorath narsaynorath enabled auto-merge (squash) May 15, 2025 22:53
@narsaynorath narsaynorath merged commit a8dc23f into master May 15, 2025
42 checks passed
@narsaynorath narsaynorath deleted the nar/feat/ui-set-scroll-restoration-to-use-pathname branch May 15, 2025 22:57
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
Prevents URL changes such as query params from changing the scroll
unexpectedly on the same path.
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants