From b5f4d50e07338206429e43ff0adc3bb3fb5267c6 Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Fri, 16 May 2025 09:36:56 -0400 Subject: [PATCH 1/5] add default symbol server for game engines --- src/sentry/api/helpers/default_symbol_sources.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/sentry/api/helpers/default_symbol_sources.py b/src/sentry/api/helpers/default_symbol_sources.py index 0bff63033ede41..f6e42ba93c522c 100644 --- a/src/sentry/api/helpers/default_symbol_sources.py +++ b/src/sentry/api/helpers/default_symbol_sources.py @@ -4,7 +4,9 @@ DEFAULT_SYMBOL_SOURCES = { "electron": ["ios", "microsoft", "electron"], "javascript-electron": ["ios", "microsoft", "electron"], - "unity": ["unity"], + "unity": ["unity", "nvidia", "ubuntu"], + "unreal-engine": ["nvidia", "ubuntu"], + "godot": ["nvidia", "ubuntu"], } From de437c7c8705ff2464ced13e1ca06829b9b188ae Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Fri, 16 May 2025 12:51:40 -0400 Subject: [PATCH 2/5] tests --- .../api/endpoints/test_team_projects.py | 49 +++++++++++++++++-- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/tests/sentry/api/endpoints/test_team_projects.py b/tests/sentry/api/endpoints/test_team_projects.py index 03c2ceeee301af..f0f640026316dc 100644 --- a/tests/sentry/api/endpoints/test_team_projects.py +++ b/tests/sentry/api/endpoints/test_team_projects.py @@ -368,8 +368,8 @@ def test_builtin_symbol_sources_not_electron(self): def test_builtin_symbol_sources_unity(self): """ - Test that project option for builtin symbol sources contains ["unity"] when creating - a Unity project, but uses defaults for other platforms. + Test that project option for builtin symbol sources contains relevant buckets + when creating a Unity project, but uses defaults for other platforms. """ response = self.get_success_response( self.organization.slug, @@ -385,7 +385,50 @@ def test_builtin_symbol_sources_unity(self): symbol_sources = ProjectOption.objects.get_value( project=unity_project, key="sentry:builtin_symbol_sources" ) - assert symbol_sources == ["unity"] + assert symbol_sources == ["unity", "nvidia", "ubuntu"] + + def test_builtin_symbol_sources_unreal(self): + """ + Test that project option for builtin symbol sources contains relevant buckets + when creating a Unreal project, but uses defaults for other platforms. + """ + response = self.get_success_response( + self.organization.slug, + self.team.slug, + name="unreal-app", + slug="unreal-app", + platform="unreal", + status_code=201, + ) + + unreal_project = Project.objects.get(id=response.data["id"]) + assert unreal_project.platform == "unreal" + unreal_project = ProjectOption.objects.get_value( + project=unreal_project, key="sentry:builtin_symbol_sources" + ) + assert symbol_sources == ["nvidia", "ubuntu"] + + + def test_builtin_symbol_sources_godot(self): + """ + Test that project option for builtin symbol sources contains relevant buckets + when creating a Godot project, but uses defaults for other platforms. + """ + response = self.get_success_response( + self.organization.slug, + self.team.slug, + name="godot-app", + slug="godot-app", + platform="godot", + status_code=201, + ) + + godot_project = Project.objects.get(id=response.data["id"]) + assert godot_project.platform == "godot" + symbol_sources = ProjectOption.objects.get_value( + project=godot_project, key="sentry:builtin_symbol_sources" + ) + assert symbol_sources == ["nvidia", "ubuntu"] @patch("sentry.api.endpoints.team_projects.TeamProjectsEndpoint.create_audit_entry") def test_create_project_with_origin(self, create_audit_entry): From 7d00fc4a57b4e01025860551026a79fa5a8ff2ec Mon Sep 17 00:00:00 2001 From: "getsantry[bot]" <66042841+getsantry[bot]@users.noreply.github.com> Date: Fri, 16 May 2025 16:55:20 +0000 Subject: [PATCH 3/5] :hammer_and_wrench: apply pre-commit fixes --- tests/sentry/api/endpoints/test_team_projects.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/sentry/api/endpoints/test_team_projects.py b/tests/sentry/api/endpoints/test_team_projects.py index f0f640026316dc..1c9eab64111bee 100644 --- a/tests/sentry/api/endpoints/test_team_projects.py +++ b/tests/sentry/api/endpoints/test_team_projects.py @@ -408,7 +408,6 @@ def test_builtin_symbol_sources_unreal(self): ) assert symbol_sources == ["nvidia", "ubuntu"] - def test_builtin_symbol_sources_godot(self): """ Test that project option for builtin symbol sources contains relevant buckets From 439c9eef0ec37c28de004b9c32eee80385ac93a0 Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Fri, 16 May 2025 15:39:52 -0400 Subject: [PATCH 4/5] fix tests --- tests/sentry/api/endpoints/test_team_projects.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/sentry/api/endpoints/test_team_projects.py b/tests/sentry/api/endpoints/test_team_projects.py index 1c9eab64111bee..6a51434e2ebe87 100644 --- a/tests/sentry/api/endpoints/test_team_projects.py +++ b/tests/sentry/api/endpoints/test_team_projects.py @@ -403,7 +403,7 @@ def test_builtin_symbol_sources_unreal(self): unreal_project = Project.objects.get(id=response.data["id"]) assert unreal_project.platform == "unreal" - unreal_project = ProjectOption.objects.get_value( + symbol_sources = ProjectOption.objects.get_value( project=unreal_project, key="sentry:builtin_symbol_sources" ) assert symbol_sources == ["nvidia", "ubuntu"] From 98b141e3b48510d788b6c5eb4bcefa18b270b4c6 Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Fri, 16 May 2025 18:10:12 -0400 Subject: [PATCH 5/5] Update src/sentry/api/helpers/default_symbol_sources.py --- src/sentry/api/helpers/default_symbol_sources.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sentry/api/helpers/default_symbol_sources.py b/src/sentry/api/helpers/default_symbol_sources.py index f6e42ba93c522c..f55bd71b3c246d 100644 --- a/src/sentry/api/helpers/default_symbol_sources.py +++ b/src/sentry/api/helpers/default_symbol_sources.py @@ -5,7 +5,7 @@ "electron": ["ios", "microsoft", "electron"], "javascript-electron": ["ios", "microsoft", "electron"], "unity": ["unity", "nvidia", "ubuntu"], - "unreal-engine": ["nvidia", "ubuntu"], + "unreal": ["nvidia", "ubuntu"], "godot": ["nvidia", "ubuntu"], }