Skip to content

feat(insights): changes to eap toggle for ea #91800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented May 16, 2025

  1. Make eap the default if the flag is enabled
  2. Remove eap toggle on all pages except backend overview (this is because the backend overview page has a new layout, whereas the other pages are just a dataset swap primarily)
  3. Update eap toggle to say "switch to old ui" and "switch to new ui"
  4. useInsightsEap is now updated to always prioritize the useEap query param (we'll use this for testing between datasets internally, but customers aren't expected to use this). It also checks against the new backend ui being enabled
  5. Ditch useSyncedLocalStorageState, it seems to be a little flakey, instead we'll just update the query params when the user switches between the "old ui" and "new ui"
  6. Don't show the eap toggle, if the next.js toggle is active

@DominikB2014 DominikB2014 requested a review from a team as a code owner May 16, 2025 14:48
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 16, 2025
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@DominikB2014 DominikB2014 merged commit d334f15 into master May 16, 2025
44 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-493-changes-to-experiment-selector-for-ea branch May 16, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants