fix(eap-alerts): Use the correct entity key #91801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
phacops
approved these changes
May 16, 2025
❌ Unsupported file format
|
shruthilayaj
deleted the
shruthi/fix/use-correct-entity-key-eap-subscriptions
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
Also updates all the integration tests to not mock snuba calls. These tests should have caught that EntityKey.EAPSpans was no longer an available option. Also tests creating + updating + deleting a subscription in a single tests since `create` uses a new RPC whereas `delete` uses an older endpoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates all the integration tests to not mock snuba calls.
These tests should have caught that EntityKey.EAPSpans was
no longer an available option.
Also tests creating + updating + deleting a subscription in a
single tests since
createuses a new RPC whereasdeleteuses an older endpoint