Skip to content

feat(profiling): Drop deprecated profiling sdks data #91804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

Zylphrex
Copy link
Member

This will start dropping profiling data from deprecated sdks when the flag is enabled.

This will start dropping profiling data from deprecated sdks when the flag is enabled.
@Zylphrex Zylphrex requested review from a team as code owners May 16, 2025 16:32
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 11 lines in your changes missing coverage. Please review.

Error parsing JUnit XML in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml at 1:159171

Caused by:
RuntimeError: Error validating attribute

Caused by:
    string is too long
Files with missing lines Patch % Lines
src/sentry/profiles/task.py 76.47% 8 Missing ⚠️
src/sentry/models/projectsdk.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #91804    +/-   ##
========================================
  Coverage   87.64%   87.65%            
========================================
  Files       10344    10346     +2     
  Lines      586155   586331   +176     
  Branches    22545    22545            
========================================
+ Hits       513746   513935   +189     
+ Misses      71963    71950    -13     
  Partials      446      446            

@Zylphrex Zylphrex merged commit 6583c97 into master May 16, 2025
60 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/drop-deprecated-profiling-sdks-data branch May 16, 2025 19:44
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
This will start dropping profiling data from deprecated sdks when the
flag is enabled.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants