feat(js): Add timezone providers #91805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
commented
May 16, 2025
| @@ -74,14 +73,13 @@ export function DateTime({ | |||
| // UTC time. | |||
| timeZone: timeZone ?? utc, | |||
| seconds, | |||
| ...options, | |||
There was a problem hiding this comment.
This was a mistake before. We were spreading the entire user.options object into the getFormat function.
ryan953
reviewed
May 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91805 +/- ##
==========================================
- Coverage 80.27% 80.27% -0.01%
==========================================
Files 10348 10348
Lines 586564 586563 -1
Branches 22574 22574
==========================================
- Hits 470880 470879 -1
Misses 114452 114452
Partials 1232 1232 |
JonasBa
reviewed
May 16, 2025
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-js-add-timezoneprovider
branch
from
8734977 to
174e081
Compare
evanpurkhiser
changed the title
ryan953
reviewed
May 16, 2025
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-js-add-timezoneprovider
branch
3 times, most recently
from
a352a67 to
14deb5d
Compare
ryan953
reviewed
May 16, 2025
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-js-add-timezoneprovider
branch
from
14deb5d to
6560288
Compare
ryan953
approved these changes
May 16, 2025
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-js-add-timezoneprovider
branch
from
6560288 to
ec186b8
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-js-add-timezoneprovider
branch
from
ec186b8 to
283e982
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-js-add-timezoneprovider
branch
from
283e982 to
e90978e
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-js-add-timezoneprovider
branch
from
e90978e to
c4d54f9
Compare
ryan953
approved these changes
May 16, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
This implements a new top-level provider that provides the timezone to
components like `<DateTime />`. This provider exposes two provider
components and one hook.
By default the provider uses the browsers timezone.
- `useTimezone` - Get the currently set timezone by the user
- `TimezoneProvider` - The simplest provider that provides the timezone
using the interface
```tsx
<TimezoneProvider timezone="America/Los_Angeles">
...
</TimezoneProvider>
```
- `UserTimezoneProvider` - Provides the timezone from the `ConfigStore`
user. Reacts to
changes to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new top-level provider that provides the timezone to
components like
<DateTime />. This provider exposes two provider components and one hook.By default the provider uses the browsers timezone.
useTimezone- Get the currently set timezone by the userTimezoneProvider- The simplest provider that provides the timezone using the interfaceUserTimezoneProvider- Provides the timezone from theConfigStoreuser. Reacts tochanges to the user.