fix(taskworker) Pass project_id to find_channel_id_for_rule #91810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't pass project to this task as projects cannot be json encoded.
github-actions
bot
added
the
Scope: Backend
markstory
commented
May 16, 2025
| @@ -800,6 +800,7 @@ def post(self, request: Request, project) -> Response: | |||
| "name": data["name"], | |||
| "environment": data.get("environment"), | |||
| "project": project, | |||
| "project_id": project.id, | |||
There was a problem hiding this comment.
Because find_channel_id_for_rule accepts kwargs adding this parameter will be safe. I'll still need a second change to remove the project parameter.
Codecov ReportAttention: Patch coverage is Error parsing JUnit XML in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml at 1:159171 Caused by:
Additional details and impacted files@@ Coverage Diff @@
## master #91810 +/- ##
===========================================
+ Coverage 32.73% 80.29% +47.56%
===========================================
Files 8741 10348 +1607
Lines 487207 586396 +99189
Branches 22554 22554
===========================================
+ Hits 159477 470836 +311359
+ Misses 327284 115114 -212170
Partials 446 446 |
cathteng
approved these changes
May 16, 2025
markstory
added a commit
that referenced
this pull request
May 16, 2025
Continues #91810 by changing the call sites to not pass `project` anymore.
markstory
added a commit
that referenced
this pull request
May 20, 2025
Continues #91810 by changing the call sites to not pass `project` anymore.
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
We can't pass project to this task as projects cannot be json encoded.
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
Continues #91810 by changing the call sites to not pass `project` anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't pass project to this task as projects cannot be json encoded.