Skip to content

chore(ACI): Remove comparison value logging #91811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

ceorourke
Copy link
Member

The logs have served their purpose and can be removed.

@ceorourke ceorourke requested a review from a team as a code owner May 16, 2025 17:56
@ceorourke ceorourke requested a review from a team May 16, 2025 17:56
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Error parsing JUnit XML in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml at 1:159067

Caused by:
RuntimeError: Error validating attribute

Caused by:
    string is too long
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #91811      +/-   ##
==========================================
+ Coverage   85.25%   87.64%   +2.39%     
==========================================
  Files       10347    10349       +2     
  Lines      586384   586405      +21     
  Branches    22559    22559              
==========================================
+ Hits       499922   513979   +14057     
+ Misses      86016    71980   -14036     
  Partials      446      446              

@ceorourke ceorourke merged commit 8f78035 into master May 16, 2025
60 checks passed
@ceorourke ceorourke deleted the ceorourke/rm-comparison-agg-logging branch May 16, 2025 18:15
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
The logs have served their purpose and can be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants