feat(trace-eap-waterfall): Sorting attributes. #91814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abdkhan14
commented
May 16, 2025
Abdkhan14
commented
github-actions
bot
added
the
Scope: Frontend
DominikB2014
approved these changes
May 16, 2025
Comment on lines
+93
to
+99
| if (aIsSpan && !bIsSpan) { | ||
| return -1; | ||
| } | ||
| if (!aIsSpan && bIsSpan) { | ||
| return 1; | ||
| } | ||
| return a.name.localeCompare(b.name); |
There was a problem hiding this comment.
Suggested change
| if (aIsSpan && !bIsSpan) { | |
| return -1; | |
| } | |
| if (!aIsSpan && bIsSpan) { | |
| return 1; | |
| } | |
| return a.name.localeCompare(b.name); | |
| return (bIsSpan - aIsSpan) || a.name.localeCompare(b.name); |
I think this works, bit more concise, slightly harder to read
There was a problem hiding this comment.
yeah a lil bit harder to read imo 🤔
There was a problem hiding this comment.
Feel free to ignore, i like the readable one
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
<img width="816" alt="Screenshot 2025-05-16 at 2 33 50 PM" src="https://github.com/user-attachments/assets/8aaaa9cb-f6f2-4339-9364-0cf1f8a7af62" /> Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.