Skip to content

feat(taxonomy): Add setup prompts to empty states #91828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

feat(taxonomy): Add setup prompts to empty states #91828

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e614aca
Add setup promps to empty states
MichaelSun48 May 16, 2025
2f537d3
Update copy and links
MichaelSun48 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions static/app/views/issueList/noGroupsHandler/noIssuesMatched.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,19 @@ import {navigateTo} from 'sentry/actionCreators/navigation';
import ExternalLink from 'sentry/components/links/externalLink';
import {t, tct} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import {useLocation} from 'sentry/utils/useLocation';
import useOrganization from 'sentry/utils/useOrganization';
import useRouter from 'sentry/utils/useRouter';

function NoIssuesMatched() {
const organization = useOrganization();
const router = useRouter();

const location = useLocation();
const onBreachedMetricsView = location.pathname.endsWith('/issues/breached-metrics/');
const onWarningsView = location.pathname.endsWith('/issues/warnings/');
const onErrorsAndOutagesView = location.pathname.endsWith('/issues/errors-outages/');

return (
<Wrapper data-test-id="empty-state" className="empty-state">
<img src={campingImg} alt="Camping spot illustration" height={200} />
Expand Down Expand Up @@ -48,6 +55,28 @@ function NoIssuesMatched() {
}
)}
</li>
{(onBreachedMetricsView || onWarningsView) && (
<li>
{tct('Make sure tracing is set up in your project. [link]', {
link: (
<ExternalLink href="https://docs.sentry.io/platform-redirect/?next=%2Ftracing%2F">
{t('Learn more')}
</ExternalLink>
),
})}
</li>
)}
{onErrorsAndOutagesView && (
<li>
{tct('Make sure uptime monitoring is set up in your project. [link]', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And cron monitoring

The learn mores feel weird - thoughts on just linking to those inline? Ex: "Make sure [cron] and [uptime] monitoring are set up in your project." and "Make sure [tracing] is set up in your project."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i like that! the learn more was just following the pattern from bullet point above

link: (
<ExternalLink href="https://docs.sentry.io/product/alerts/uptime-monitoring/">
{t('Learn more')}
</ExternalLink>
),
})}
</li>
)}
</Tips>
</MessageContainer>
</Wrapper>
Expand Down
Loading