feat(grouping): Add helper to combine hints #91833
Merged
+76
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a frame is affected by both an in-app rule and a contributes rule, the split enhancements allow us to get both hints, rather than having one clobber the other (as is the case now). That does not mean, however, that both hints are always relevant. This PR adds a helper,
_combine_hints
, to appropriately use or ignore each hint, and combine them when necessary. It's not yet used, but will be when we switch to actually using the split enhancements, rather than just running them alongside the non-split ones.Note that
_combine_hints
needs the finalcontributes
value to already be in place when it runs, so this also moves the setting of that value earlier inassemble_stacktrace_component
.