feat(aci): Setup detector details #91834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
# Conflicts: # static/app/views/detectors/detail.tsx
# Conflicts: # static/app/types/workflowEngine/dataConditions.tsx
# Conflicts: # static/app/types/workflowEngine/dataConditions.tsx
ameliahsu
approved these changes
May 21, 2025
TkDodo
reviewed
May 22, 2025
| @@ -68,12 +52,19 @@ export enum DataConditionGroupLogicType { | |||
| NONE = 'none', | |||
| } | |||
|
|
|||
| export const enum DetectorPriorityLevel { | |||
There was a problem hiding this comment.
FYI, this enum is unused so I’ve deleted it in:
Please don’t add unused code that is needed in the future because it is indistinguishable from dead code that can be deleted - try to add code at the time when it is used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly unfinished but opening pr in case someone else picks it up or starts looking at these shared types