test(widgets): Increase timeout for widget loading #91839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove check that the spinner exists since it seems to flake if the loading indicator has already disappeared, also seems to flake if it takes longer than expected in CI. https://app.codecov.io/github/getsentry/sentry/tests/master?flags%5B0%5D=frontend&historicalTrend=INTERVAL_7_DAY
github-actions
bot
added
the
Scope: Frontend
roggenkemper
approved these changes
May 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91839 +/- ##
==========================================
- Coverage 82.60% 80.21% -2.40%
==========================================
Files 10350 10350
Lines 586599 586599
Branches 22574 22574
==========================================
- Hits 484534 470513 -14021
- Misses 100833 114854 +14021
Partials 1232 1232 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove check that the spinner exists since it seems to flake if the loading indicator has already disappeared, also seems to flake if it takes longer than expected in CI.
https://app.codecov.io/github/getsentry/sentry/tests/master?flags%5B0%5D=frontend&historicalTrend=INTERVAL_7_DAY