Skip to content

feat(rules): Wrap IntegrationEventAction future callbacks in a span #91850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

kcons
Copy link
Member

@kcons kcons commented May 16, 2025

Add a wrapper span to our future callbacks to improve tracing of actions.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 16, 2025
Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157001 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91850       +/-   ##
===========================================
+ Coverage   32.72%   87.62%   +54.90%     
===========================================
  Files        8751    10359     +1608     
  Lines      487748   586894    +99146     
  Branches    22586    22586               
===========================================
+ Hits       159617   514276   +354659     
+ Misses     327706    72193   -255513     
  Partials      425      425               

@kcons kcons enabled auto-merge (squash) May 19, 2025 17:13
@kcons kcons merged commit ea84093 into master May 19, 2025
60 checks passed
@kcons kcons deleted the kcons/spanit branch May 19, 2025 17:27
Copy link

sentry-io bot commented May 19, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ IntegrationFormError: {'issuetype': ['The issue type selected is invalid.']} sentry.tasks.post_process.post_process_group View Issue
  • ‼️ IntegrationInstallationConfigurationError: Could not fetch issue create configuration from Jira. sentry.rules.processing.delayed_processing View Issue
  • ‼️ IntegrationFormError: {'reporter': ['The reporter specified is not a user.']} sentry.rules.processing.delayed_processing View Issue
  • ‼️ RateLimitExceeded: Query on could not be run due to allocation policies, info: {'details': {'ConcurrentRateLimitAllocationPolicy': {'can_run': False, 'max_threads': 0, 'explanation': {'reason': 'concurrent policy 17 exceeds limit of 16', 'overrides': {}, 'storage_key': 'S... sentry.tasks.post_process.post_process_group View Issue
  • ‼️ RateLimitExceeded: Query on could not be run due to allocation policies, info: {'details': {'ConcurrentRateLimitAllocationPolicy': {'can_run': False, 'max_threads': 0, 'explanation': {'reason': 'concurrent policy 18 exceeds limit of 16', 'overrides': {}, 'storage_key': 'S... sentry.tasks.post_process.post_process_group View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
…91850)

Add a wrapper span to our future callbacks to improve tracing of
actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants