fix(replay): Expand replay user.geo tag if an object is found #91885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
approved these changes
May 20, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
This is a followup on #91869 and #91854 to fix [JAVASCRIPT-30NR](https://sentry.io/organizations/sentry/issues/?project=11276&query=JAVASCRIPT-30NR) Now we're taking special care to unpack the `user.geo.*` fields and show them as individual tags: <img width="605" alt="SCR-20250519-kmta" src="https://github.com/user-attachments/assets/ebb74fbf-0a21-4f67-8f21-c4e6a2fcf16d" /> --- I tried using [`flattie`](https://www.npmjs.com/package/flattie) which is already part of our package.json but it was recursing into our arrays which we expect as the final values from the db. Dealing with that would require a manual recursive pass, which defeats the purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on #91869 and #91854 to fix JAVASCRIPT-30NR
Now we're taking special care to unpack the
user.geo.*fields and show them as individual tags:I tried using
flattiewhich is already part of our package.json but it was recursing into our arrays which we expect as the final values from the db. Dealing with that would require a manual recursive pass, which defeats the purpose.