feat(billing): Seer subscription usage card #91888

jarrettscott · 2025-05-19T19:22:28Z

Closes: https://linear.app/getsentry/issue/BIL-547/manage-seer-product-trials-from-the-subscription-page
Closes: https://linear.app/getsentry/issue/BIL-714/create-seer-availability-banner
Closes: https://linear.app/getsentry/issue/BIL-531/detailed-seer-usage
Closes: https://linear.app/getsentry/issue/BIL-536/seer-data-available-for-reserved-usage-chart

Creates a Seer-specific usage card on the subscription page. Combines Autofix and Scanner information into a single usage table.

This PR also supports the standard product trial functionality.

codecov · 2025-05-19T19:27:41Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
10447	2	10445	9

View the top 2 failed test(s) by shortest run time

hasCategoryFeature returns sorted categories with keys

Stack Traces | 0.008s run time

Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  -  0
+ Received  + 20

@@ -117,6 +117,26 @@
        "trueForward": false,
        "usage": 0,
        "usageExceeded": false,
      },
    ],
+   Array [
+     "seerAutofix",
+     Object {
+       "category": "seerScanner",
+       "customPrice": 0,
+       "free": 0,
+       "onDemandBudget": 0,
+       "onDemandQuantity": 0,
+       "onDemandSpendUsed": 0,
+       "order": 13,
+       "paygCpe": 0,
+       "prepaid": 0,
+       "reserved": 0,
+       "sentUsageWarning": false,
+       "softCapType": null,
+       "trueForward": false,
+       "usage": 0,
+       "usageExceeded": false,
+     },
+   ],
  ]
    at Object.<anonymous> (.../gsApp/utils/dataCategory.spec.tsx:138:71)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

hasCategoryFeature returns sorted categories

Stack Traces | 0.022s run time

Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  -  0
+ Received  + 17

@@ -99,6 +99,23 @@
      "softCapType": null,
      "trueForward": false,
      "usage": 0,
      "usageExceeded": false,
    },
+   Object {
+     "category": "seerScanner",
+     "customPrice": 0,
+     "free": 0,
+     "onDemandBudget": 0,
+     "onDemandQuantity": 0,
+     "onDemandSpendUsed": 0,
+     "order": 13,
+     "paygCpe": 0,
+     "prepaid": 0,
+     "reserved": 0,
+     "sentUsageWarning": false,
+     "softCapType": null,
+     "trueForward": false,
+     "usage": 0,
+     "usageExceeded": false,
+   },
  ]
    at Object.<anonymous> (.../gsApp/utils/dataCategory.spec.tsx:101:63)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

…iption-page

brendanhsentry

This doesn't include usage data or on-demand spend for scanner

brendanhsentry · 2025-05-20T20:27:19Z

The zero state (no seer purchased) and product trial don't match the figma designs

static/gsApp/views/subscriptionPage/overview.tsx

…iption-page

isabellaenriquez

if possible, we should move to using availableReservedBudgetTypes; the current implementation is confusing with both seer and DS

static/gsApp/constants.tsx

brendanhsentry · 2025-05-28T19:39:52Z

static/gsApp/views/subscriptionPage/overview.tsx

@@ -192,24 +192,53 @@ function Overview({location, subscription, promotionData}: Props) {
      nonPlanProductTrials?.filter(pt => pt.category === DataCategory.PROFILES).length >
        0 || false;

-    const showAllBudgetTotals = subscription.hadCustomDynamicSampling ? true : false;
+    const showAllBudgetTotals = subscription.hadCustomDynamicSampling;


This still doesn't include usage data for scanner. We'll need to update this so showAllBudgetTotals is true for all subscriptions that are eligible to Seer. This allows us to combine usage stat totals in the UsageTotals component. Similar to the code snippet below.

sentry/static/gsApp/views/subscriptionPage/usageTotals.tsx

Lines 828 to 842 in 78c53b1

{hasReservedBudget &&

subscription.hadCustomDynamicSampling &&

allTotalsByCategory &&

subscription.reservedBudgets?.map(budget =>

Object.entries(budget.categories)

// Filter out the current category since it's already shown from logic above

.filter(([categoryKey]) => categoryKey !== category)

.map(([categoryKey]) => (

<UsageTotalsTable

key={categoryKey}

category={categoryKey as DataCategory}

totals={allTotalsByCategory?.[categoryKey] ?? EMPTY_STAT_TOTAL}

subscription={subscription}

/>

))

isabellaenriquez

worth noting that this card behavior is strange on self-serve; even if you toggle to Usage mode, it still shows all the Seer info in spend mode

static/gsApp/views/subscriptionPage/usageTotals.tsx

tests/js/getsentry-test/fixtures/subscription.ts

isabellaenriquez · 2025-05-29T01:31:46Z

tested locally just now, some places for improvement:

the reserved usage chart does not display info for issue fixes and scans
the issue scans table does not reflect the real stats (i ingested scans but the table says 0 accepted)
the usage card does not breakdown the prepaid nor ondemand usage into the two SKUs
the usage card does not reflect the total on-demand usage (i have on-demand usage just for scans but the card says $0)

jarrettscott · 2025-05-30T04:07:09Z

Closing. Refactored into #92450

display combined Seer usage card

7758f39

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 19, 2025

vercel bot deployed to Preview May 19, 2025 19:25 View deployment

Merge remote-tracking branch 'origin/master' into jarrett/seer-subscr…

bdade16

…iption-page

vercel bot deployed to Preview May 19, 2025 20:54 View deployment

jarrettscott added 2 commits May 19, 2025 21:38

fix tests

41cd4a6

canProductTrial

c8a347e

vercel bot deployed to Preview May 20, 2025 16:16 View deployment

update gsBanner test

3b27da3

vercel bot deployed to Preview May 20, 2025 17:29 View deployment

jarrettscott changed the title ~~feat(billing): Display combined Seer usage card~~ feat(billing): Seer subscription usage card May 20, 2025

jarrettscott marked this pull request as ready for review May 20, 2025 19:57

jarrettscott requested a review from a team as a code owner May 20, 2025 19:57

brendanhsentry reviewed May 20, 2025

View reviewed changes

static/gsApp/views/subscriptionPage/overview.tsx Outdated Show resolved Hide resolved

updated Seer card states

15d58db

vercel bot deployed to Preview May 22, 2025 00:28 View deployment

fix various Seer states

d1772e6

vercel bot deployed to Preview May 27, 2025 16:08 View deployment

jarrettscott added 2 commits May 27, 2025 09:29

Merge remote-tracking branch 'origin/master' into jarrett/seer-subscr…

fede9af

…iption-page

expandable with active trial

da7280c

vercel bot deployed to Preview May 27, 2025 16:51 View deployment

isabellaenriquez reviewed May 27, 2025

View reviewed changes

static/gsApp/constants.tsx Outdated Show resolved Hide resolved

jarrettscott requested a review from isabellaenriquez May 27, 2025 23:52

scanner usage and canProductTrial

95bacd9

vercel bot deployed to Preview May 28, 2025 16:51 View deployment

fix test

29c11c4

vercel bot deployed to Preview May 28, 2025 17:37 View deployment

dashed approved these changes May 28, 2025

View reviewed changes

brendanhsentry reviewed May 28, 2025

View reviewed changes

isabellaenriquez reviewed May 28, 2025

View reviewed changes

refactoring

777acf8

vercel bot deployed to Preview May 28, 2025 22:02 View deployment

updated showReservedInfo

9b58c2f

vercel bot deployed to Preview May 28, 2025 22:07 View deployment

showAllBudgetTotals and fixture updates

ab606c4

vercel bot deployed to Preview May 28, 2025 23:35 View deployment

fixture test fixes

69756a4

vercel bot deployed to Preview May 28, 2025 23:54 View deployment

jarrettscott closed this May 30, 2025

jarrettscott deleted the jarrett/seer-subscription-page branch June 2, 2025 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(billing): Seer subscription usage card #91888

feat(billing): Seer subscription usage card #91888

Uh oh!

jarrettscott commented May 19, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 19, 2025 •

edited

Loading

Uh oh!

brendanhsentry left a comment

Uh oh!

brendanhsentry commented May 20, 2025

Uh oh!

Uh oh!

isabellaenriquez left a comment

Uh oh!

Uh oh!

brendanhsentry May 28, 2025

Uh oh!

isabellaenriquez left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isabellaenriquez commented May 29, 2025

Uh oh!

jarrettscott commented May 30, 2025

Uh oh!

Uh oh!

	{hasReservedBudget &&
	subscription.hadCustomDynamicSampling &&
	allTotalsByCategory &&
	subscription.reservedBudgets?.map(budget =>
	Object.entries(budget.categories)
	// Filter out the current category since it's already shown from logic above
	.filter(([categoryKey]) => categoryKey !== category)
	.map(([categoryKey]) => (
	<UsageTotalsTable
	key={categoryKey}
	category={categoryKey as DataCategory}
	totals={allTotalsByCategory?.[categoryKey] ?? EMPTY_STAT_TOTAL}
	subscription={subscription}
	/>
	))

Uh oh!

feat(billing): Seer subscription usage card #91888

feat(billing): Seer subscription usage card #91888

Uh oh!

Conversation

jarrettscott commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

brendanhsentry left a comment

Choose a reason for hiding this comment

Uh oh!

brendanhsentry commented May 20, 2025

Uh oh!

Uh oh!

isabellaenriquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brendanhsentry May 28, 2025

Choose a reason for hiding this comment

Uh oh!

isabellaenriquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isabellaenriquez commented May 29, 2025

Uh oh!

jarrettscott commented May 30, 2025

Uh oh!

Uh oh!

jarrettscott commented May 19, 2025 •

edited

Loading

codecov bot commented May 19, 2025 •

edited

Loading