Skip to content

ref: have AlertRule.detection_type code match schema width #91898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

asottile-sentry
Copy link
Member

the migration which added this column added it as varchar(32) but this was not reflected in code until now -- fix it with a state-only migration

the migration which added this column added it as varchar(32) but this was not reflected in code until now -- fix it with a state-only migration
@asottile-sentry asottile-sentry requested review from a team as code owners May 19, 2025 21:05
@asottile-sentry asottile-sentry enabled auto-merge (squash) May 19, 2025 21:05
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 19, 2025
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0902_detection_type_match_size.py

for 0902_detection_type_match_size in sentry

--
-- Custom state/database change combination
--
-- (no-op)

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157237 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91898       +/-   ##
===========================================
+ Coverage   61.11%   87.62%   +26.51%     
===========================================
  Files       10351    10356        +5     
  Lines      586733   586956      +223     
  Branches    22585    22585               
===========================================
+ Hits       358582   514332   +155750     
+ Misses     227723    72196   -155527     
  Partials      428      428               

@asottile-sentry asottile-sentry merged commit 32d999a into master May 19, 2025
60 checks passed
@asottile-sentry asottile-sentry deleted the asottile-detection-type-proper-width branch May 19, 2025 21:25
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
the migration which added this column added it as varchar(32) but this
was not reflected in code until now -- fix it with a state-only
migration

<!-- Describe your PR here. -->
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants