diff --git a/src/sentry/api/serializers/models/rule.py b/src/sentry/api/serializers/models/rule.py index 0e2bbc307b84cf..12727d7f634099 100644 --- a/src/sentry/api/serializers/models/rule.py +++ b/src/sentry/api/serializers/models/rule.py @@ -422,7 +422,7 @@ def _fetch_workflow_last_triggered(self, item_list: Sequence[Workflow]) -> dict[ result_qs = reduce( lambda q1, q2: q1.union(q2), [ - WorkflowFireHistory.objects.filter(workflow=item, has_fired_actions=True) + WorkflowFireHistory.objects.filter(workflow=item) .order_by("-date_added") .values("workflow_id", "date_added")[:1] for item in item_list diff --git a/src/sentry/workflow_engine/processors/action.py b/src/sentry/workflow_engine/processors/action.py index d0fd1bb8dcb75d..c229e74cb96d13 100644 --- a/src/sentry/workflow_engine/processors/action.py +++ b/src/sentry/workflow_engine/processors/action.py @@ -83,8 +83,6 @@ def create_workflow_fire_histories( workflow_id=workflow_id, group=event_data.event.group, event_id=event_data.event.event_id, - has_passed_filters=True, - has_fired_actions=True, ) for workflow_id in workflow_ids ] diff --git a/tests/sentry/api/serializers/test_rule.py b/tests/sentry/api/serializers/test_rule.py index 4a895c8bd8a5c5..247efb26e52a12 100644 --- a/tests/sentry/api/serializers/test_rule.py +++ b/tests/sentry/api/serializers/test_rule.py @@ -56,7 +56,6 @@ def assert_equal_serializers(self, issue_alert): WorkflowFireHistory.objects.create( workflow=workflow, group=self.group, - has_fired_actions=True, event_id="fc6d8c0c43fc4630ad850ee518f1b9d0", ) @@ -213,15 +212,13 @@ def test_fetch_workflow_last_triggered(self): workflow_2 = self.create_workflow() WorkflowFireHistory.objects.create(workflow=workflow, group=self.group, event_id="asdf") - WorkflowFireHistory.objects.create( - workflow=workflow, group=self.group, event_id="jklm", has_fired_actions=True - ) + WorkflowFireHistory.objects.create(workflow=workflow, group=self.group, event_id="jklm") wfh = WorkflowFireHistory.objects.create( - workflow=workflow_2, group=self.group, event_id="qwer", has_fired_actions=True + workflow=workflow_2, group=self.group, event_id="qwer" ) wfh.update(date_added=before_now(days=1)) wfh_2 = WorkflowFireHistory.objects.create( - workflow=workflow_2, group=self.group, event_id="fdsa", has_fired_actions=True + workflow=workflow_2, group=self.group, event_id="fdsa" ) wfh_2.update(date_added=before_now(hours=1)) diff --git a/tests/sentry/workflow_engine/processors/test_action.py b/tests/sentry/workflow_engine/processors/test_action.py index 10ebc05e8c75ed..e353994e3d58cd 100644 --- a/tests/sentry/workflow_engine/processors/test_action.py +++ b/tests/sentry/workflow_engine/processors/test_action.py @@ -93,8 +93,6 @@ def test_create_workflow_fire_histories(self): workflow=self.workflow, group=self.group, event_id=self.group_event.event_id, - has_passed_filters=True, - has_fired_actions=True, ).count() == 1 ) diff --git a/tests/sentry/workflow_engine/processors/test_delayed_workflow.py b/tests/sentry/workflow_engine/processors/test_delayed_workflow.py index b9a8e26916dee9..e9110121d6777e 100644 --- a/tests/sentry/workflow_engine/processors/test_delayed_workflow.py +++ b/tests/sentry/workflow_engine/processors/test_delayed_workflow.py @@ -828,16 +828,12 @@ def test_fire_actions_for_groups__workflow_fire_history(self, mock_process): workflow=self.workflow2, group_id=self.group2.id, event_id=self.event2.event_id, - has_passed_filters=True, - has_fired_actions=True, ).exists() assert WorkflowFireHistory.objects.filter( workflow=self.workflow1, group_id=self.group1.id, event_id=self.event1.event_id, - has_passed_filters=True, - has_fired_actions=True, ).exists() diff --git a/tests/sentry/workflow_engine/processors/test_workflow.py b/tests/sentry/workflow_engine/processors/test_workflow.py index aede6994835e4e..02eb37f48e315d 100644 --- a/tests/sentry/workflow_engine/processors/test_workflow.py +++ b/tests/sentry/workflow_engine/processors/test_workflow.py @@ -628,7 +628,6 @@ def test_creates_histories(self): workflow=self.workflow, group=self.group, event_id=self.group_event.event_id, - has_fired_actions=True, ).count() == 1 )