chore(aci): manually add spans for delayed workflow processing #91908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
saponifi3d
approved these changes
May 19, 2025
Comment on lines
+517
to
+529
| project = fetch_project(project_id) | ||
| if not project: | ||
| return | ||
|
|
||
| workflow_event_dcg_data = fetch_group_to_event_data(project_id, Workflow, batch_key) | ||
| workflow_event_dcg_data = fetch_group_to_event_data(project_id, Workflow, batch_key) | ||
|
|
||
| # Get mappings from DataConditionGroups to other info | ||
| dcg_to_groups, trigger_group_to_dcg_model = get_dcg_group_workflow_detector_data( | ||
| workflow_event_dcg_data | ||
| ) | ||
| dcg_to_workflow = trigger_group_to_dcg_model[DataConditionHandler.Group.WORKFLOW_TRIGGER].copy() | ||
| dcg_to_workflow.update(trigger_group_to_dcg_model[DataConditionHandler.Group.ACTION_FILTER]) | ||
| # Get mappings from DataConditionGroups to other info | ||
| dcg_to_groups, trigger_group_to_dcg_model = get_dcg_group_workflow_detector_data( | ||
| workflow_event_dcg_data | ||
| ) | ||
| dcg_to_workflow = trigger_group_to_dcg_model[ | ||
| DataConditionHandler.Group.WORKFLOW_TRIGGER | ||
| ].copy() |
There was a problem hiding this comment.
nit: should this be moved into a method to make it a little easier to read? perhaps naming it prepare_data? 🤔
There was a problem hiding this comment.
err well there's the early return if there's no project
There was a problem hiding this comment.
the return type starts looking a little crazy if i put it all into a single function, so just going to keep it separate for now
Codecov ReportAttention: Patch coverage is
|
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...try/workflow_engine/processors/delayed_workflow.py | 4.16% | 23 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## master #91908 +/- ##
==========================================
- Coverage 87.63% 87.62% -0.01%
==========================================
Files 10356 10356
Lines 587133 587141 +8
Branches 22585 22585
==========================================
+ Hits 514506 514510 +4
- Misses 72199 72203 +4
Partials 428 428
jan-auer
added a commit
that referenced
this pull request
May 20, 2025
* master: (58 commits) link: cleanup link (#91687) ref: create project_id index for organizationonboardingtask (#91918) storybook: smaller last edited (#91875) issues: fix chonk stacktrace alignment (#91891) alert: drop custom alert (#91892) insights: fix bar height (#91895) ref(span-buffer): Move max-memory-percentage to right CLI (#91924) ref(js): Factor button functionality (#91763) tests(resolve_groups): Clean up the tests (#91779) ref(span-buffer): Add backpressure (#91707) fix(nextjs-insights): project id is not passed to explore link (#91920) fix(crons): Floor seconds / microsecond on recorded dateClock (#91890) fix(uptime): Fix bug with the uptime_checks dataset in the events endpoint (#91824) ref: add state-only migration to reflect existing indexes in prod (#91901) ref: remove unnecssary metaclass (#91906) fix(stats): use data category title name (#91913) feat(issues): Add success messages to some actions (#91899) test(taskworker): Lower exec time (#91907) chore(aci): manually add spans for delayed workflow processing (#91908) chore(aci): remove uses of WorkflowFireHistory rollout columns (#91904) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like for delayed rule processing #91764, we should track the performance of delayed workflow processing. We need to manually add spans though.