chore(aci): pending delete WorkflowFireHistory rollout columns

[cathteng]

Follow up to #91904

Set the unused columns to pending deletion according to https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-columns

[cathteng]

this table has 43 mil rows. should this and/or the follow up migration to actually delete the columns be post deploy?

[cathteng]

it's not being written to very often anymore (kind of exploded last week, but that change has been rolled back and updated to only write for workflows that fire actions)

[vgrozdanic]

this table has 43 mil rows. should this and/or the follow up migration to actually delete the columns be post deploy?

Nope, neither of them should be post deployment.

We have it in our docs, but it is a bit hidden, column removals should never be post deployment operations: https://develop.sentry.dev/backend/application-domains/database-migrations/#post-deploy-migrations-is_post_deployment

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0063_drop_rollout_workflowfirehistory_columns.py

for 0063_drop_rollout_workflowfirehistory_columns in workflow_engine

--
-- Moved workflowfirehistory.has_fired_actions field to pending deletion state
--
-- (no-op)
--
-- Moved workflowfirehistory.has_passed_filters field to pending deletion state
--
-- (no-op)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157237 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #91910   +/-   ##
=======================================
  Coverage   87.62%   87.63%           
=======================================
  Files       10356    10357    +1     
  Lines      587133   587137    +4     
  Branches    22585    22585           
=======================================
+ Hits       514493   514512   +19     
+ Misses      72212    72197   -15     
  Partials      428      428