chore(ACI): Add metric for dual processing in metric alerts #91979
+37
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
commented
May 20, 2025
| "organizations:workflow-engine-metric-alert-dual-processing-logs", | ||
| self.subscription.project.organization, | ||
| ): | ||
| metrics.incr("dual_processing.alert_rules.fire") |
There was a problem hiding this comment.
I don't need the detection type to filter out anomaly detection alerts (which are not yet migrated) because those get fired and resolved in the if block above this
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
kcons
approved these changes
May 20, 2025
saponifi3d
approved these changes
May 20, 2025
cathteng
approved these changes
May 20, 2025
Comment on lines
+474
to
+477
| if features.has( | ||
| "organizations:workflow-engine-metric-alert-dual-processing-logs", | ||
| self.subscription.project.organization, | ||
| ): |
There was a problem hiding this comment.
nit: pull into its own variable so we don't have to check the feature flag twice here
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
Follow up to #91840 The `organization_id` tag is not showing up in Datadog despite manually allowing it for these metrics (I suspect something higher up is blocking it) so this PR removes that tag and adds a metric behind the logging flag for metric alerts firing so that we can see if they are firing at the same rate as in workflow engine.
ceorourke
added a commit
that referenced
this pull request
May 22, 2025
Follow up to #91979 to only track when there is at least one action in `process_workflows` and differentiate between fires and resolves in the subscription processor. Previously I wanted them added together but now that we've realized we're not reaching `process_workflows` for resolutions I want to be able to determine if the number of fires is accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #91840
The
organization_idtag is not showing up in Datadog despite manually allowing it for these metrics (I suspect something higher up is blocking it) so this PR removes that tag and adds a metric behind the logging flag for metric alerts firing so that we can see if they are firing at the same rate as in workflow engine.