feat(profiles): accept compressed data #92003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
john-z-yang
force-pushed
the
john/profiles-accept-compressed
branch
from
d0201c5 to
8d216b6
Compare
john-z-yang
commented
May 21, 2025
john-z-yang
commented
May 21, 2025
markstory
reviewed
May 21, 2025
src/sentry/profiles/task.py
Outdated
|
|
||
| def decode_payload(encoded: str) -> dict[str, Any]: | ||
|
|
||
| def decode_payload(encoded: str | bytes) -> dict[str, Any]: |
There was a problem hiding this comment.
We could eliminate bytes here and in the task signature as the profiles consumer is always sending str now.
There was a problem hiding this comment.
Sounds good, done. Removed tests that encodes into bytes as well
john-z-yang
force-pushed
the
john/profiles-accept-compressed
branch
from
8d216b6 to
c6cafe6
Compare
john-z-yang
force-pushed
the
john/profiles-accept-compressed
branch
from
c6cafe6 to
1a6b2d3
Compare
john-z-yang
force-pushed
the
john/profiles-accept-compressed
branch
from
1a6b2d3 to
4d39f18
Compare
enochtangg
approved these changes
May 22, 2025
roaga
pushed a commit
that referenced
this pull request
May 22, 2025
hack to start migrating profiles to zlib compression. This lets the function support both kinds of encoded strings (compressed and uncompressed) The rollout plan is as follows: 1. Rollout this change 2. Rollout the pr where we can compress a portion of the profile activations 3. Once 100% of all profiles activation is compressed, we can remove the delimiter symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hack to start migrating profiles to zlib compression. This lets the function support both kinds of encoded strings (compressed and uncompressed)
The rollout plan is as follows: