fix(project-install): Render request errors at the bottom if any & disable project if rule is being created #92022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
commented
May 21, 2025
Comment on lines
+417
to
+423
| setErrors(error.responseJSON); | ||
| addErrorMessage(t('Failed to create project %s', `${projectName}`)); |
There was a problem hiding this comment.
The error response format is inconsistent. Sometimes it's a flat object with arrays, like:
{
"actions": [
"Slack: The resource \"error\" does not exist or has not been granted access in the Sentry Slack workspace."
]
}Other times, it follows a different structure. For now, I’ve kept the existing logic mostly as-is and focused on fixing the immediate issue. We can revisit this later and improve error handling more cleanly.
priscilawebdev
force-pushed
the
priscila/fix/project-creation/error-not-shown-when-invalid-slack-channel
branch
from
be19b38 to
527c626
Compare
priscilawebdev
changed the title
priscilawebdev
changed the title
priscilawebdev
commented
May 22, 2025
| @@ -153,24 +157,19 @@ export function CreateProject() { | |||
| project, | |||
| alertRuleConfig, | |||
| }: {project: Project} & Pick<FormData, 'alertRuleConfig'>) => { | |||
| const ruleIds = []; | |||
| const ruleIds: Array<string | undefined> = []; | |||
There was a problem hiding this comment.
the createPlatform function is getting complex - happy to clean it up in a follow-up
…own-when-invalid-slack-channel
priscilawebdev
commented
May 22, 2025
| @@ -238,7 +235,10 @@ export function CreateProject() { | |||
| ].filter(value => value).length; | |||
|
|
|||
| const canSubmitForm = | |||
| !createProject.isPending && canUserCreateProject && formErrorCount === 0; | |||
| !createProjectRules.isPending && | |||
There was a problem hiding this comment.
When a rule is being created, the primary button should be disabled as well because the request may fail
priscilawebdev
changed the title
|
will open a follow-up PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Screen.Recording.2025-05-21.at.14.56.22.mov
After
Screen.Recording.2025-05-21.at.14.58.06.mov
closes TET-443