feat(Codecov): add Codecov repository picker #92068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianviquez
changed the title
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| export interface RepoSelectorProps { | ||
| onChange: (data: string) => void; | ||
| /** | ||
| * Repository date value |
There was a problem hiding this comment.
wrong comment right?
Comment on lines
15
to
17
| const currentParams = new URLSearchParams(location.search); | ||
| currentParams.set('repository', newRepository); | ||
| navigate(`${location.pathname}?${currentParams.toString()}`, {replace: true}); |
There was a problem hiding this comment.
Would using the const [searchParams, setSearchParams] = useSearchParams(); hook work for you here? It looks like only the search params are being changed right? I think the hook is slightly lighter weight. I used it for my radio selector switching but I'm trying to decide if one is better than the other for both cases or if they should be different.
There was a problem hiding this comment.
Sgtm, I'll change that in a sec!
calvin-codecov
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the RepoPicker and RepoSelector components as well as adding them to the Test page.
Notes
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.