Skip to content

chore(ACI): Update metric issue dual processing metrics #92076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

ceorourke
Copy link
Member

Follow up to #91979 to only track when there is at least one action in process_workflows and differentiate between fires and resolves in the subscription processor. Previously I wanted them added together but now that we've realized we're not reaching process_workflows for resolutions I want to be able to determine if the number of fires is accurate.

@ceorourke ceorourke requested review from a team as code owners May 21, 2025 21:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156309 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #92076   +/-   ##
=======================================
  Coverage   82.75%   82.76%           
=======================================
  Files       10168    10168           
  Lines      582904   582907    +3     
  Branches    22595    22595           
=======================================
+ Hits       482410   482424   +14     
+ Misses      99206    99195   -11     
  Partials     1288     1288           

@ceorourke ceorourke merged commit 75e743d into master May 22, 2025
60 checks passed
@ceorourke ceorourke deleted the ceorourke/update-dual-proc-metrics branch May 22, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants