fix(aci): 404 for non-digit IDs in endpoints #92087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
wedamija
approved these changes
May 22, 2025
roaga
pushed a commit
that referenced
this pull request
May 22, 2025
Change our URL regexes to only recognize numeric IDs. This doesn't avoid issues from >2**64 numbers, but we can come back with a Model.id-bounds-aware ID parser on all endpoints if that ends up mattering. Fixes #92083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change our URL regexes to only recognize numeric IDs.
This doesn't avoid issues from >2**64 numbers, but we can come back with a Model.id-bounds-aware ID parser on all endpoints if that ends up mattering.
Fixes #92083