feat(issues): Avoid hiding unread indicator #92088
Open
+35
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the checkbox down below the unread indicator.
github-actions
bot
added
the
Scope: Frontend
malwilley
reviewed
May 22, 2025
scttcper
commented
May 22, 2025
| @@ -172,6 +172,7 @@ const GroupExtra = styled('div')` | |||
| font-size: ${p => p.theme.fontSizeSmall}; | |||
| white-space: nowrap; | |||
| line-height: 1.2; | |||
| min-height: ${space(2)}; | |||
There was a problem hiding this comment.
group extras were not the same height. extras were sometimes 12 or 16px depending on if they had replay indicator etc
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92088 +/- ##
===========================================
+ Coverage 40.47% 82.76% +42.28%
===========================================
Files 10145 10168 +23
Lines 582238 582693 +455
Branches 22627 22579 -48
===========================================
+ Hits 235649 482242 +246593
+ Misses 346137 99163 -246974
- Partials 452 1288 +836 |
malwilley
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the checkbox down below the unread indicator. Breaks the checkbox displaying on focus but fixes an issue where the checkbox would stay visible after unchecking. Fixes https://linear.app/getsentry/issue/RTC-861/separate-selection-ui-from-unread-indicator
after
