Skip to content

fix(taskworker) Fix parameter size collection #92090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

markstory
Copy link
Member

I forgot that celery-beat injects kombu objects into task parameters.

I forgot that celery-beat injects kombu objects into task parameters.
@markstory markstory requested a review from a team May 22, 2025 03:11
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156414 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Files with missing lines Patch % Lines
src/sentry/celery.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92090      +/-   ##
==========================================
+ Coverage   84.08%   87.87%   +3.79%     
==========================================
  Files       10170    10172       +2     
  Lines      582941   582969      +28     
  Branches    22603    22603              
==========================================
+ Hits       490140   512312   +22172     
+ Misses      92348    70204   -22144     
  Partials      453      453              

@markstory markstory merged commit 340f48b into master May 22, 2025
61 checks passed
@markstory markstory deleted the fix-parameter-size-loggin branch May 22, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants