Skip to content

feat(quick-start): Remove animation and reordering #92096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented May 22, 2025

  • Removes all animations present in the Quick Start
  • No longer reorder tasks based on their status
  • Adds a strike to the task's title indicating that it was done/skipped

Note
Depending on feedback, we can remove all the code related to the completionSeen as it was only used for the animation

Preview

Screen.Recording.2025-05-22.at.10.54.58.mov

closes TET-387

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 22, 2025
…ng' of github.com:getsentry/sentry into priscila/feat/quick-start/remove-animation-and-reordering
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92096      +/-   ##
==========================================
- Coverage   87.88%   84.08%   -3.81%     
==========================================
  Files       10172    10170       -2     
  Lines      582989   582923      -66     
  Branches    22605    22602       -3     
==========================================
- Hits       512347   490125   -22222     
- Misses      70191    92345   +22154     
- Partials      451      453       +2     

@priscilawebdev priscilawebdev marked this pull request as ready for review May 22, 2025 09:16
@priscilawebdev priscilawebdev requested a review from a team May 22, 2025 09:16
@shellmayr
Copy link
Member

A quick visual feedback - could we grey the tasks that are marked as completed out a little?

@priscilawebdev
Copy link
Member Author

great feedback @shellmayr does it look better?
image

Copy link
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants