-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(quick-start): Remove animation and reordering #92096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
priscilawebdev
wants to merge
7
commits into
master
Choose a base branch
from
priscila/feat/quick-start/remove-animation-and-reordering
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(quick-start): Remove animation and reordering #92096
priscilawebdev
wants to merge
7
commits into
master
from
priscila/feat/quick-start/remove-animation-and-reordering
+44
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng' of github.com:getsentry/sentry into priscila/feat/quick-start/remove-animation-and-reordering
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92096 +/- ##
==========================================
- Coverage 87.88% 84.08% -3.81%
==========================================
Files 10172 10170 -2
Lines 582989 582923 -66
Branches 22605 22602 -3
==========================================
- Hits 512347 490125 -22222
- Misses 70191 92345 +22154
- Partials 451 453 +2 |
priscilawebdev
commented
May 22, 2025
A quick visual feedback - could we grey the tasks that are marked as completed out a little? |
great feedback @shellmayr does it look better? |
shellmayr
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Depending on feedback, we can remove all the code related to the
completionSeen
as it was only used for the animationPreview
Screen.Recording.2025-05-22.at.10.54.58.mov
closes TET-387