feat(widget-builder): Cache builder state between dataset changes #92122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either restore the old state if it exists, or push the dataset change through the original way the widget builder hook works.
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
approved these changes
May 23, 2025
static/app/views/dashboards/widgetBuilder/hooks/useCacheBuilderState.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either restore the old state if it exists, or push the dataset change through the original way the widget builder hook works.
Note: We have to purposely ignore the
titleanddescriptionfields because a user should not have those values change if they return to a cached state with a different title/description.