-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(aci): return sentry app component title in available action endpoint #92138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
how the project rule configuration endpoint returns this value, for reference
we will now be handling the connecting words ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, what happens if the title doesn't exist?
if component: | ||
sentry_app["settings"] = component.app_schema.get("settings", {}) | ||
if component.app_schema.get("title"): | ||
sentry_app["title"] = component.app_schema.get("title") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunate we need to do this - i wish we had the ability to type this down. can we put a todo somewhere for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the component schema is just an open field so it might be hard to do 😭
schema: models.Field[dict[str, Any], dict[str, Any]] = JSONField() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamrajjoshi if the title doesn't exist we just use the sentry app's name |
If available, we need to return the sentry app component's title to display in the frontend
In this example, the title is
Create a Linear issue