Skip to content

feat(insights): make failure_rate generic to any span #92140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented May 22, 2025

Previously failure_rate was specific to trace.status and it was used to show transaction failure_rate, however this doesn't work generically for any span type. This Pr updates failure_rate to be generic to any span type by using span.status instead. For transaction spans, span.status is trace.status anyways so it will still work as expected, this can be verified in explore

@DominikB2014 DominikB2014 requested a review from a team as a code owner May 22, 2025 17:59
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156719 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #92140       +/-   ##
===========================================
+ Coverage   59.00%   87.87%   +28.86%     
===========================================
  Files       10175    10181        +6     
  Lines      583070   583456      +386     
  Branches    22613    22613               
===========================================
+ Hits       344061   512691   +168630     
+ Misses     238557    70313   -168244     
  Partials      452      452               

@DominikB2014 DominikB2014 merged commit fc2b75d into master May 23, 2025
62 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-491-update-failure_rate-to-be-generic branch May 23, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants