feat(insights): make failure_rate
generic to any span
#92140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
failure_rate
was specific totrace.status
and it was used to show transaction failure_rate, however this doesn't work generically for any span type. This Pr updatesfailure_rate
to be generic to any span type by usingspan.status
instead. For transaction spans,span.status
istrace.status
anyways so it will still work as expected, this can be verified in explore