Skip to content

ref: make is_active db_default true on organizationmemberteam replica table #92141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

JoshFerge
Copy link
Member

following up on #92064, doing it on the control silo replica table as well.

@JoshFerge JoshFerge requested a review from a team as a code owner May 22, 2025 18:00
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 22, 2025
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0912_make_organizationmemberteam_replica_is_active_true.py

for 0912_make_organizationmemberteam_replica_is_active_true in sentry

--
-- Alter field is_active on organizationmemberteamreplica
--
ALTER TABLE "sentry_organizationmember_teamsreplica" ALTER COLUMN "is_active" SET DEFAULT true;

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156615 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #92141       +/-   ##
===========================================
+ Coverage   41.74%   77.77%   +36.02%     
===========================================
  Files       10152    10179       +27     
  Lines      582428   583520     +1092     
  Branches    22632    22632               
===========================================
+ Hits       243120   453818   +210698     
+ Misses     338856   129250   -209606     
  Partials      452      452               

@JoshFerge JoshFerge merged commit d16fbf0 into master May 22, 2025
60 checks passed
@JoshFerge JoshFerge deleted the jferg/remove-active-from-replica branch May 22, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants