build(rspack): Add back moment IgnorePlugin #92149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was missing from the rspack config for some reason but is required to lazy load the locale/moment chunks we create. Added a comment that describes the purpose.
github-actions
bot
added
the
Scope: Frontend
billyvg
reviewed
May 22, 2025
| */ | ||
| // new SentryInstrumentation(), |
There was a problem hiding this comment.
If this was removed, we should remove the module in build-utils as well
There was a problem hiding this comment.
its still in webpack, can do later
billyvg
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was missing from the rspack config for some reason. It is required to lazy load the locale/moment chunks we create. Added a comment that describes the purpose. Also moved the similar plugins together.