Skip to content

fix(aci): Add an initial UptimeSubscription serializer #92150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Conversation

kcons
Copy link
Member

@kcons kcons commented May 22, 2025

Add UptimeSubscriptionSerializer to allow Detector endpoints to return successfully.
Detector data source subscription types need to be serializable for the detectors APIs.
Add a test to verify that we can return a serialized uptime detector; the specifics of the fields serialized are more a question for uptime folks and not yet relevant, so the serialization result contents are left untested.

@kcons kcons requested review from a team as code owners May 22, 2025 19:57
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 22, 2025
Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - cc @wedamija incase you have any thoughts on this (it's just meant to unblock some other dev)

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:156718 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92150      +/-   ##
==========================================
- Coverage   85.56%   85.56%   -0.01%     
==========================================
  Files       10179    10179              
  Lines      583480   583539      +59     
  Branches    22627    22627              
==========================================
+ Hits       499254   499304      +50     
- Misses      83631    83640       +9     
  Partials      595      595              

@kcons kcons merged commit 3eac465 into master May 23, 2025
61 checks passed
@kcons kcons deleted the kcons/cereal branch May 23, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants