From 618056068e92c7d95004c0a696e18ebf6ec2606b Mon Sep 17 00:00:00 2001 From: Mark Story Date: Thu, 22 May 2025 16:24:22 -0400 Subject: [PATCH] fix(taskworker) Remove high-throughput setting We added this setting when options checks for taskworkers were expensive (because we used isset()), now that we've made option reads cheaper via get(), we shouldn't need this setting. --- src/sentry/conf/server.py | 1 - src/sentry/tasks/base.py | 17 ++++++----------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/sentry/conf/server.py b/src/sentry/conf/server.py index fb31f37e59e925..69057bb8e48ca3 100644 --- a/src/sentry/conf/server.py +++ b/src/sentry/conf/server.py @@ -1510,7 +1510,6 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str: }, } -TASKWORKER_ENABLE_HIGH_THROUGHPUT_NAMESPACES = False TASKWORKER_HIGH_THROUGHPUT_NAMESPACES = { "ingest.profiling", "ingest.transactions", diff --git a/src/sentry/tasks/base.py b/src/sentry/tasks/base.py index 9d1b59ab1f2c39..d425477ec35bc7 100644 --- a/src/sentry/tasks/base.py +++ b/src/sentry/tasks/base.py @@ -75,17 +75,12 @@ def taskworker_override( def override(*args: P.args, **kwargs: P.kwargs) -> R: rollout_rate = 0 option_flag = f"taskworker.{namespace}.rollout" - check_option = True - if namespace in settings.TASKWORKER_HIGH_THROUGHPUT_NAMESPACES: - check_option = settings.TASKWORKER_ENABLE_HIGH_THROUGHPUT_NAMESPACES - - if check_option: - rollout_map = options.get(option_flag) - if rollout_map: - if task_name in rollout_map: - rollout_rate = rollout_map.get(task_name, 0) - elif "*" in rollout_map: - rollout_rate = rollout_map.get("*", 0) + rollout_map = options.get(option_flag) + if rollout_map: + if task_name in rollout_map: + rollout_rate = rollout_map.get(task_name, 0) + elif "*" in rollout_map: + rollout_rate = rollout_map.get("*", 0) if rollout_rate > random.random(): return taskworker_attr(*args, **kwargs)