-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
ref: soft delete omt is_active #92164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JoshFerge
wants to merge
2
commits into
master
Choose a base branch
from
jferg/remove-is-active
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+55
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has a migration; here is the generated SQL for for --
-- Moved organizationmemberteam.is_active field to pending deletion state
--
-- (no-op) |
|
Tests completed | Failed | Passed | Skipped |
---|---|---|---|
25957 | 23 | 25934 | 207 |
View the top 3 failed test(s) by shortest run time
tests.sentry.manager.test_project_manager.ProjectManagerTest::test_get_by_users_empty
Stack Traces | 0.096s run time
#x1B[1m#x1B[.../sentry/manager/test_project_manager.py#x1B[0m:51: in test_get_by_users_empty assert Project.objects.get_by_users([]) == {} #x1B[1m#x1B[.../sentry/models/project.py#x1B[0m:173: in get_by_users project_rows = self.filter( #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1491: in filter return self._filter_or_exclude(False, args, kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1509: in _filter_or_exclude clone._filter_or_exclude_inplace(negate, args, kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1516: in _filter_or_exclude_inplace self._query.add_q(Q(*args, **kwargs)) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1643: in add_q clause, _ = self._add_q(q_object, can_reuse) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1675: in _add_q child_clause, needed_inner = self.build_filter( #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1585: in build_filter condition = self.build_lookup(lookups, col, value) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1406: in build_lookup lhs = self.try_transform(lhs, lookup_name) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1455: in try_transform raise FieldError( #x1B[1m#x1B[31mE django.core.exceptions.FieldError: Unsupported lookup 'is_active' for ManyToOneRel or join on the field not permitted.#x1B[0m
tests.sentry.api.test_issue_search.ConvertActorOrNoneValueTest::test_my_team
Stack Traces | 2.01s run time
#x1B[1m#x1B[.../sentry/api/test_issue_search.py#x1B[0m:357: in test_my_team assert convert_actor_or_none_value( #x1B[1m#x1B[.../sentry/api/issue_search.py#x1B[0m:103: in convert_actor_or_none_value actors_or_none.extend(get_teams_for_users(projects, [user])) #x1B[1m#x1B[.../sentry/search/utils.py#x1B[0m:315: in get_teams_for_users id__in=OrganizationMemberTeam.objects.filter( #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1491: in filter return self._filter_or_exclude(False, args, kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1509: in _filter_or_exclude clone._filter_or_exclude_inplace(negate, args, kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1516: in _filter_or_exclude_inplace self._query.add_q(Q(*args, **kwargs)) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1643: in add_q clause, _ = self._add_q(q_object, can_reuse) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1675: in _add_q child_clause, needed_inner = self.build_filter( #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1523: in build_filter lookups, parts, reffed_expression = self.solve_lookup_type(arg, summarize) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1330: in solve_lookup_type _, field, _, lookup_parts = self.names_to_path(lookup_splitted, self.get_meta()) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1802: in names_to_path raise FieldError( #x1B[1m#x1B[31mE django.core.exceptions.FieldError: Cannot resolve keyword 'is_active' into field. Choices are: id, organizationmember, organizationmember_id, role, team, team_id#x1B[0m
tests.sentry.api.test_issue_search.ConvertQueryValuesTest::test_valid_assign_my_teams_converter
Stack Traces | 2.16s run time
#x1B[1m#x1B[.../sentry/api/test_issue_search.py#x1B[0m:183: in test_valid_assign_my_teams_converter expected = value_converters["assigned_to"]([raw_value], [self.project], self.user, None) #x1B[1m#x1B[.../sentry/api/issue_search.py#x1B[0m:103: in convert_actor_or_none_value actors_or_none.extend(get_teams_for_users(projects, [user])) #x1B[1m#x1B[.../sentry/search/utils.py#x1B[0m:315: in get_teams_for_users id__in=OrganizationMemberTeam.objects.filter( #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/manager.py#x1B[0m:87: in manager_method return getattr(self.get_queryset(), name)(*args, **kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1491: in filter return self._filter_or_exclude(False, args, kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1509: in _filter_or_exclude clone._filter_or_exclude_inplace(negate, args, kwargs) #x1B[1m#x1B[31m.venv/lib/python3.13.../db/models/query.py#x1B[0m:1516: in _filter_or_exclude_inplace self._query.add_q(Q(*args, **kwargs)) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1643: in add_q clause, _ = self._add_q(q_object, can_reuse) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1675: in _add_q child_clause, needed_inner = self.build_filter( #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1523: in build_filter lookups, parts, reffed_expression = self.solve_lookup_type(arg, summarize) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1330: in solve_lookup_type _, field, _, lookup_parts = self.names_to_path(lookup_splitted, self.get_meta()) #x1B[1m#x1B[31m.venv/lib/python3.13.../models/sql/query.py#x1B[0m:1802: in names_to_path raise FieldError( #x1B[1m#x1B[31mE django.core.exceptions.FieldError: Cannot resolve keyword 'is_active' into field. Choices are: id, organizationmember, organizationmember_id, role, team, team_id#x1B[0m
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
soft delete organizationmemberteam.is_active, as it's no longer used.