Skip to content

feat(spans): Compue breakdowns on segment spans #92185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2025

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented May 23, 2025

Computes breakdowns as measurements that ultimately get converted to span
attributes. Once we have a specification for span breakdowns in span data, this
implementation can be updated.

Follows the implementation in Relay from getsentry/relay#1260 and
getsentry/relay#4600.

Closes VIEPF-5
Requires getsentry/sentry-kafka-schemas#411

@jan-auer jan-auer requested a review from a team as a code owner May 23, 2025 07:51
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try/spans/consumers/process_segments/enrichment.py 95.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #92185      +/-   ##
==========================================
+ Coverage   87.86%   87.93%   +0.07%     
==========================================
  Files       10179    10184       +5     
  Lines      583128   583796     +668     
  Branches    22612    22612              
==========================================
+ Hits       512351   513378    +1027     
+ Misses      70325    69966     -359     
  Partials      452      452              

@jan-auer jan-auer merged commit a9d6793 into master May 23, 2025
62 checks passed
@jan-auer jan-auer deleted the feat/segments-breakdowns branch May 23, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants